This repository has been archived by the owner on Sep 19, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Improve error categorization and cross-platform reporting #64
Milestone
Comments
There should be a well-known separator between the error identifier/category and the rest of the message. Is
|
2 tasks
ghost
assigned linuxwolf
Dec 20, 2017
linuxwolf
changed the title
Adhere to convention with error messages
Reasons as Strings instead of Symbols
Jan 8, 2018
@mozilla-lockbox/engineering Updated the issue description to reflect the consensus. |
sandysage
added
backlog
We have looked at and understand the issue. Prioritized with alignment to product initiatives.
and removed
backlog
We have looked at and understand the issue. Prioritized with alignment to product initiatives.
labels
Jan 11, 2018
mistakenly closed via #71. |
linuxwolf
changed the title
Reasons as Strings instead of Symbols
Improve error categorization and cross-platform reporting
Jan 24, 2018
linuxwolf
added
the
backlog
We have looked at and understand the issue. Prioritized with alignment to product initiatives.
label
Feb 5, 2018
sandysage
added
to do
and removed
backlog
We have looked at and understand the issue. Prioritized with alignment to product initiatives.
labels
Feb 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In service to sync, the categories of errors (i.e., reasons) needs to be expanded to account for the various condition that can occur. Additionally, the reasons need to be represented in a manner that is understandable to machines and developers across process and platform boundaries.
The additional errors to be handled are covered in sync.
The machine-actionable "reason" is enumerated and reported via a JavaScript Symbol. However, this has some drawbacks:
The above means a Symbol gets lost whenever the error crosses a process boundary, either as a structured clone or JSON stringification.
For the widest compatibility, the
reason
property ofDataStoreError
should be a String instead of a Symbol. Additionally, for improved diagnostic purposes, this reason string should be conveyed in the error message.Related
The text was updated successfully, but these errors were encountered: