Skip to content
This repository has been archived by the owner on Sep 19, 2018. It is now read-only.

Define relevancy APIs for exposing data #17

Open
linuxwolf opened this issue Aug 31, 2017 · 9 comments
Open

Define relevancy APIs for exposing data #17

linuxwolf opened this issue Aug 31, 2017 · 9 comments
Labels

Comments

@linuxwolf
Copy link
Contributor

linuxwolf commented Aug 31, 2017

The purpose of this API is to allow a content script to check if the datastore might have credentials for the current web page.

The API should take the URL, and return back some sort of indication there is (or is not) at least one relevant item. The implementation should not require the datastore to be unlocked in order to return positive results.

@linuxwolf linuxwolf changed the title Search APIs Define Search APIs Aug 31, 2017
@devinreams
Copy link
Contributor

@linuxwolf @jimporter given we first need lock/unlock #6 how confident do you feel about building search as part of Alpha?

@jimporter
Copy link

It'd be pretty easy to make a super-simple search interface for alpha.

@linuxwolf
Copy link
Contributor Author

It should be fairly easy to do a basic "substring" search over title and username, all in the "./manage" view.

@linuxwolf
Copy link
Contributor Author

for possible inspiration, or a base: https://github.com/enkidevs/react-search-input

@devinreams devinreams changed the title Define Search APIs Define relevancy APIs for exposing data Sep 15, 2017
@devinreams
Copy link
Contributor

Added a front-end issue for search interface:
mozilla-lockwise/lockbox-extension#80

Talked with @linuxwolf and this items purpose should be more around a 'search the page and send back relevant data' API, for lack of better words right now.

@jimporter
Copy link

As an initial implementation, I was planning on doing all this in the front-end. It would probably be best to put it in the backend eventually, but that adds some complexity to the data synchronization that I don't want to get into for alpha.

@linuxwolf
Copy link
Contributor Author

linuxwolf commented Sep 15, 2017

Updated the description to limit its scope.

This functionality something that can only really be done in the back-end.

@jimporter
Copy link

Oh, right. That's a bit different than the question Devin was asking me. Still, it might make sense to have search in the backend too. We can discuss that elsewhere, though.

@devinreams devinreams added feature backlog We have looked at and understand the issue. Prioritized with alignment to product initiatives. labels Nov 1, 2017
@sandysage
Copy link

Given where we're initially going with autofill mozilla-lockwise/lockbox-extension#467, moving this back to the inbox for now.

@sandysage sandysage removed the backlog We have looked at and understand the issue. Prioritized with alignment to product initiatives. label Jan 22, 2018
@devinreams devinreams removed backlog We have looked at and understand the issue. Prioritized with alignment to product initiatives. MVP P1-must-have labels Mar 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants