Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure compatiblity between carl of pycarl and carl of Storm #82

Open
volkm opened this issue Aug 4, 2022 · 2 comments
Open

Ensure compatiblity between carl of pycarl and carl of Storm #82

volkm opened this issue Aug 4, 2022 · 2 comments

Comments

@volkm
Copy link
Contributor

volkm commented Aug 4, 2022

  • We should check both carl versions (used in pycarl and Storm) to ensure they are the same. (Maybe even check the carl_DIR used during compilation?)
  • It is possible that pycarl has disabled the cln support and Storm is compiled with CLN. This currently yields an ImportError. It would be good to catch it already at the build stage.
@sjunges
Copy link
Contributor

sjunges commented Sep 18, 2022

Isnt this fixed?

@volkm
Copy link
Contributor Author

volkm commented Sep 18, 2022

No, not yet. We are currently checking that the pybind version is the same between pycarl and stormpy (cf. #86). We are however not yet checking that the carl version (and the support for CLN) between pycarl and Storm is the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sjunges @volkm