Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Eigen Version during Config #366

Closed
sjunges opened this issue May 12, 2023 · 4 comments
Closed

Check Eigen Version during Config #366

sjunges opened this issue May 12, 2023 · 4 comments

Comments

@sjunges
Copy link
Contributor

sjunges commented May 12, 2023

Errors like

$ cat /Users/Mees_1/storm/build/carl-prefix/src/carl-stamp/carl-build-err.log
clang: warning: argument unused during compilation: '-msse' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-msse2' [-Wunused-command-line-argument]
/Users/Mees_1/storm/build/resources/3rdparty/carl_download/source_dir/src/carl/core/rootfinder/EigenWrapper.cpp:3:10: fatal error: 'eigen3/Eigen/Dense' file not found in #include <eigen3/Eigen/Dense>

seem to originate from using a wrong preinstalled eigen version. It would be helpful to detect such errors during configuration to clarify that this is a problem with the host system. We could e.g. check whether the include compiles (cmake has some nice functions that support these checks).

@tquatmann
Copy link
Member

I agree, but shouldn't this be an issue of carl-storm ?

@sjunges
Copy link
Contributor Author

sjunges commented Oct 22, 2023

Don't we forward the EIGEN version from Storm?

@tquatmann
Copy link
Member

No, Storm ships it's own eigen version which is currently only used within Storm.
It might be possible to use that also in Carl but that would mean that carl-storm in some way depends on storm (or at least storm's build infrastructure).

@sjunges
Copy link
Contributor Author

sjunges commented Nov 12, 2023

Oops. i added an issue there moves-rwth/carl-storm#17 there and I opened an issue regarding configuring two versions of eigen here: #425

@sjunges sjunges closed this as completed Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants