Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake search for storm-carl version. #2

Open
sjunges opened this issue Dec 19, 2019 · 1 comment
Open

CMake search for storm-carl version. #2

sjunges opened this issue Dec 19, 2019 · 1 comment

Comments

@sjunges
Copy link
Contributor

sjunges commented Dec 19, 2019

Currently, we search only in the CMake registry for carl.
If storm builds carl, then carl is exported to the registry. This has some unpleasant side-effects.

Thus besides searching the registry for carl, it would be interesting to search for storm, ask whether storm has installed carl, and get that version. Then storm no longer needs to write the carl version to the cmake registry.

As a downside, storm really is not a dependency of pycarl, so it might be a bit strange to do this. On the other hand, I feel that the combination pycarl/storm is currently rather typical.

@sjunges
Copy link
Contributor Author

sjunges commented Jun 29, 2023

We may want to review this, as we now run on a carl-storm fork anyways..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant