Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(OTS) Race Condition in Parent Block Update #882

Open
l-monninger opened this issue Nov 20, 2024 · 1 comment
Open

(OTS) Race Condition in Parent Block Update #882

l-monninger opened this issue Nov 20, 2024 · 1 comment
Assignees
Labels
Source: Audit Issues discovered by audit. suzuka:safety

Comments

@l-monninger
Copy link
Collaborator

Summary

The parent_block update code here has a race condition if two threads both read the same parent_block together and only then both update the parent_block. The issue is caused by the read lock being released before the write, creating a small window where other thread might jump-in. This is currently impossible though since the sequencer only runs on a single thread, but it needs to be fixed if the single thread assumption might ever change.

@l-monninger l-monninger added Source: Audit Issues discovered by audit. suzuka:safety labels Nov 20, 2024
@l-monninger l-monninger self-assigned this Nov 20, 2024
@l-monninger
Copy link
Collaborator Author

@khokho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Source: Audit Issues discovered by audit. suzuka:safety
Projects
None yet
Development

No branches or pull requests

1 participant