Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(OTS) Mempool Transaction Key Not Initialized w/ Correct Capacity #881

Open
l-monninger opened this issue Nov 20, 2024 · 1 comment · May be fixed by #892
Open

(OTS) Mempool Transaction Key Not Initialized w/ Correct Capacity #881

l-monninger opened this issue Nov 20, 2024 · 1 comment · May be fixed by #892
Assignees
@mzabaluev
Labels
Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Source: Audit Issues discovered by audit. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. suzuka:performance

Comments

@l-monninger
Copy link
Collaborator

Summary

In construct_mempool_transaction_key the initial vector capacity won’t be enough for for the key since the id is formatted as hex. Hex encoding will take 64 bytes instead of 32 which means formula should be 32+1+32+1+32+1+64 instead.
@l-monninger l-monninger added suzuka:performance Source: Audit Issues discovered by audit. labels Nov 20, 2024
@l-monninger
Copy link
Collaborator Author

@khokho

@mzabaluev mzabaluev added Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. labels Nov 21, 2024
@mzabaluev mzabaluev linked a pull request Nov 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mzabaluev mzabaluev

Labels
Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Source: Audit Issues discovered by audit. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. suzuka:performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(mempool): pre-allocate capacity for the db key movementlabsxyz/movement
2 participants
@mzabaluev @l-monninger