Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge: test all client call. #840

Open
musitdev opened this issue Nov 12, 2024 · 2 comments
Open

Bridge: test all client call. #840

musitdev opened this issue Nov 12, 2024 · 2 comments
Assignees
Labels

Comments

@musitdev
Copy link
Contributor

Not all client contract calls are tested.
Add the missing calls.

@musitdev musitdev self-assigned this Nov 12, 2024
@0xmovses
Copy link
Contributor

Can you list the calls that are missing, and are they missing for both sides? Thanks!

@musitdev
Copy link
Contributor Author

About the Relayer calls:
The Mvt lock and initiator complete is done.
The Mvt initiate and refund
Needs:
The Eth lock and initiator complete.
The Eth initiate and refund.
The Mvt and Eth lock and counterpart Mvt and Eth Abort.

I don't think the user call (initiat_transfer and counterpart complete) should be tested here because the client uses the relayer signer account which is not the normal use case. They can be tested to see if the impl works but they are never used by the Relayer.
Initiate is done but not counterpart complete for both chain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants