Replies: 1 comment 3 replies
-
Yeah, it's leaky. GC plus this in particular equals problems. Even without GC, any other fallibility results in leakiness. A couple additional ideas:
|
Beta Was this translation helpful? Give feedback.
3 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
The v1 load shedding as implemented in #255 is leaky: it does not account for transactions that don't make it to the DA for any reason, including the DA light node garbage collection implemented in #628.
The proposed solution is to move the pressure valve entirely onto m1-da-light-node. The simplest way I see to implement this is to move the in-flight counter and the load shedding logic to m1-da-light-node mempool. The transaction pipe task in the node will add transactions to its in-memory mempool and try to submit blobs to the da-light-node, but an "enhance your calm" error status from the latter will cause it to reject incoming transactions with a "mempool is full" error until da-light-node is able to accept blobs again.
Beta Was this translation helpful? Give feedback.
All reactions