Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest Noetic forward ports to ROS 2 affected MoveIt 2 CI #251

Closed
sea-bass opened this issue Nov 26, 2024 · 3 comments
Closed

Latest Noetic forward ports to ROS 2 affected MoveIt 2 CI #251

sea-bass opened this issue Nov 26, 2024 · 3 comments

Comments

@sea-bass
Copy link

The forward ports in #239 have caused a regression in MoveIt 2 CI, which uses geometric_shapes for path constraints.

Interestingly enough, the only breakage has to do with running the main branch of MoveIt 2 on ROS 2 Humble. I suspect there is some dependency back in Ubuntu 22.04 that makes things not happy.

See moveit/moveit2#3130 for more details.

I reverted the entire commit and it does solve the issue. I'm now running a bisection of the changes to pinpoint exactly what it was. Will update this issue.


@sea-bass
Copy link
Author

sea-bass commented Nov 26, 2024

Yep. It's this: b00b1e5

@peci1 if you don't mind, I'm going to cherry-pick this to ros2 now: b00b1e5

@peci1
Copy link
Contributor

peci1 commented Nov 26, 2024

Thanks for the quick action.

I actually asked if breaking ABI on the ros2 branch is a problem, but none of the maintainers objected: #239 (review) .

Now the question is when will be the right time to remove the ABI compatibility fix... When a new ROS2 distro is branched off?

@sea-bass
Copy link
Author

sea-bass commented Nov 26, 2024

Given that the failure was only on Humble, I suspect it will be OK as soon as MoveIt's main branch is deemed no longer compatible (it still is!).

That call could actually be made now if needed, but I figured this change was resolvable.

It would mean needing to branch a humble version on this repo though.

@sea-bass sea-bass reopened this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants