Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable maximum travel time #155

Merged

Conversation

MichaelKutzner
Copy link
Contributor

This adds a new query parameter max_travel_time_ to limit results by maximum travel time.

Notice that this change also includes tests for max_transfers_, which serve a similar purpose. As these has been added to test/routing/transfer_time_settings_test.cc, the file will be renamed to test/routing/transfer_travel_test.cc.

@MichaelKutzner MichaelKutzner marked this pull request as ready for review November 21, 2024 08:31
@MichaelKutzner
Copy link
Contributor Author

Closed, as this will not prevent calculating results, that will be discarded later on.

@MichaelKutzner
Copy link
Contributor Author

Reopened, due to possible issue discovered during motis-project/motis#668

Setting an unreasonable large maxTravelTime value would disable some optimizations, if previously no fastest_direct_ were provided.

@felixguendling felixguendling merged commit 2cf648a into motis-project:master Dec 9, 2024
10 checks passed
@MichaelKutzner MichaelKutzner deleted the set_max_travel_time branch December 9, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants