Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect reader/writer initialization in examples and description #280

Open
AndreasKorn opened this issue Mar 21, 2024 · 0 comments
Open

Comments

@AndreasKorn
Copy link

The reader/writer initialization code and description in the examples is not correct and leads to bad side effects and unexpected results (You need to instantiate the classes in the init context).

Since the "init" context is executed multiple times during the script execution the readers and writers are also instantiated multiple times.
Especially for the reader (consumer) this is really bad as you will have multiple consumers in the group if you do not use a unique group id, meaning you will not get all messages.
And even if you use a unique group id multiple consumers mean more active reader meaning more load.

The writers and readers should be instantiated and cleaned up in the default function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant