Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new: add custom exchanges to rpc pattern #377

Merged
merged 1 commit into from
Sep 20, 2023
Merged

new: add custom exchanges to rpc pattern #377

merged 1 commit into from
Sep 20, 2023

Conversation

cloud-rocket
Copy link
Contributor

Extended RPC pattern to include support for custom exchanges.

This is needed when creating multiple micro-services operated via similar API

@cloud-rocket cloud-rocket force-pushed the add-custom-rpc-exchange branch from 60c6387 to 7e37074 Compare February 12, 2021 18:31
@cloud-rocket
Copy link
Contributor Author

@mosquito, what do you think?

I haven't added anything related to py35/py36 errors

@mosquito
Copy link
Owner

mosquito commented Feb 22, 2021 •
edited
Loading

@cloud-rocket please rebase against the master branch

@cloud-rocket cloud-rocket force-pushed the add-custom-rpc-exchange branch from 7e37074 to 4d86acc Compare February 22, 2021 21:18
@cloud-rocket
Copy link
Contributor Author

cloud-rocket commented Feb 22, 2021 •
edited
Loading

@mosquito,

@cloud-rocket please rebase against the master branch

done

@cloud-rocket
Copy link
Contributor Author

@mosquito ping

@cloud-rocket
Copy link
Contributor Author

Anything new with this?

Thanks

@cloud-rocket
Copy link
Contributor Author

@mosquito - any chance to merge it?

Thanks

@cloud-rocket cloud-rocket force-pushed the add-custom-rpc-exchange branch from 4d86acc to c237f93 Compare September 16, 2021 22:01
@cloud-rocket
Copy link
Contributor Author

@mosquito , it's been a while, if I will rebase this PR to the recent version, would you be able to merge it this time?

Thanks

mosquito
mosquito previously approved these changes Aug 22, 2023
View reviewed changes
@mosquito
Copy link
Owner

@cloud-rocket please rebase it against master branch

@mosquito mosquito closed this Aug 22, 2023
@mosquito mosquito reopened this Aug 22, 2023
@mosquito
Copy link
Owner

Sorry, miss clicked

@cloud-rocket cloud-rocket force-pushed the add-custom-rpc-exchange branch from c237f93 to 3c67564 Compare August 28, 2023 18:22
@cloud-rocket
Copy link
Contributor Author

@mosquito - rebased from latest master.

Please review

@coveralls
Copy link

coveralls commented Aug 28, 2023 •
edited
Loading

Coverage Status

coverage: 88.402% (+0.2%) from 88.246% when pulling 62a3268 on cloud-rocket:add-custom-rpc-exchange into c8dae1e on mosquito:master.

@cloud-rocket cloud-rocket force-pushed the add-custom-rpc-exchange branch from 3c67564 to 8092678 Compare August 28, 2023 21:40
@cloud-rocket
Copy link
Contributor Author

@mosquito - I fixed the type / styling issues. Please rerun the tests

@cloud-rocket cloud-rocket requested a review from mosquito August 29, 2023 13:30
@cloud-rocket cloud-rocket force-pushed the add-custom-rpc-exchange branch from 8092678 to fe65640 Compare August 29, 2023 15:42
@cloud-rocket
Copy link
Contributor Author

cloud-rocket commented Aug 29, 2023 •
edited
Loading

@mosquito - fixed the poetry also and tried locally (sorry, missed it 1st time). Please rerun the CI

@cloud-rocket
Copy link
Contributor Author

@mosquito, ping! Can please rerun the pipeline! Thank you!

@mosquito
Copy link
Owner

I will review it on weekends. Busy right now.

@cloud-rocket
Copy link
Contributor Author

@mosquito, I am planning to release an open-source micro-service communication and orchestration library which needs this feature. Would be great to have it merged. It is pending for 1.5 years now!

Thank you!

mosquito
mosquito requested changes Sep 5, 2023
View reviewed changes
Copy link
Owner

@mosquito mosquito left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, I've got things piling up for a couple weeks ahead, anyway I like everything except for the one single spot I commented bellow. Again, sorry it took me so long to respond.

aio_pika/patterns/rpc.py Outdated Show resolved Hide resolved
@cloud-rocket cloud-rocket force-pushed the add-custom-rpc-exchange branch from fe65640 to 6c359dc Compare September 7, 2023 15:26
@cloud-rocket
Copy link
Contributor Author

@mosquito - can you please review the update following your comment? Thanks

@cloud-rocket
Copy link
Contributor Author

@mosquito - it would be great if you could make it happen, it's a small change and I'd really like to publish another package based on it.

Thank you

mosquito
mosquito previously approved these changes Sep 15, 2023
View reviewed changes
@mosquito mosquito requested review from decaz and Alviner September 15, 2023 19:53
decaz
decaz requested changes Sep 16, 2023
View reviewed changes
aio_pika/patterns/rpc.py Outdated Show resolved Hide resolved
aio_pika/patterns/rpc.py Outdated Show resolved Hide resolved
@cloud-rocket cloud-rocket force-pushed the add-custom-rpc-exchange branch from 6c359dc to 2adce0c Compare September 18, 2023 17:54
@cloud-rocket cloud-rocket requested a review from decaz September 18, 2023 17:56
@cloud-rocket cloud-rocket force-pushed the add-custom-rpc-exchange branch from 2adce0c to 62a3268 Compare September 18, 2023 18:00
@decaz decaz requested a review from mosquito September 18, 2023 18:55
@cloud-rocket
Copy link
Contributor Author

Hi @mosquito - can you please pull this in? Thanks!

@cloud-rocket
Copy link
Contributor Author

@mosquito, I cannot publish the dependent package to the public Pypi before this PR is merged. Would appreciate your help on this. Thanks!

@mosquito mosquito merged commit b8e8eff into mosquito:master Sep 20, 2023
8 checks passed
@mosquito
Copy link
Owner

@cloud-rocket sorry for delay, a new version 9.3.0 has been released with your changes

@cloud-rocket
Copy link
Contributor Author

@mosquito, Thanks! FYI - the microservice orchestration package based on aio-pika - https://github.com/imubit/amqp-fabric

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alviner Alviner Alviner approved these changes

@decaz decaz decaz approved these changes

@mosquito mosquito Awaiting requested review from mosquito

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cloud-rocket @mosquito @coveralls @decaz @Alviner