Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photos in frames have excessive shimmering artifacts (no mipmaps) #131

Open
bravely-beep opened this issue Dec 4, 2024 · 2 comments
Open

Comments

@bravely-beep
Copy link

Photographs displayed in frames do not use mipmaps, causing severe artifacts when viewed from a distance. This is true for vanilla minecraft maps as well; however, the dithering used in Exposure's photograph's exacerbates the issue considerably, causing photographs to shimmer excessively even when viewed from relatively close distances.

This mod seems to resolve the issue for vanilla maps; perhaps a similar solution could be used here?

(Using exposure-1.20.1-1.7.7-fabric.jar)

@bravely-beep bravely-beep changed the title Photos in frames have excessive shimmering artifacts (mipmaps) Photos in frames have excessive shimmering artifacts (no mipmaps) Dec 4, 2024
@mortuusars
Copy link
Owner

I was trying to fix this one day, but to no avail.
Thanks for pointing out this mod, it's exactly what I was trying to find.
My only hope is that it'll work, because I have read somewhere that mipmapping cannot be enabled for non power of 2 texture sizes, and exposure uses non-standard texture size of 320x320.

@mortuusars
Copy link
Owner

Yep, it works! This is huge, it looks so much better now, thank you so much for sending me mapmipmapmod repo. And thanks to Jalvaviel for implementation example.
This will be part of a 1.21 port, but I'll try to backport it to prior versions as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants