Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to multiline parameters in function/method synopsis #5

Open
Wes0617 opened this issue Nov 10, 2016 · 6 comments
Open

Default to multiline parameters in function/method synopsis #5

Wes0617 opened this issue Nov 10, 2016 · 6 comments

Comments

@Wes0617
Copy link
Collaborator

Wes0617 commented Nov 10, 2016

(unless the func takes 0 args)

align

Leaves a lot of "not good looking empty space" on the right, on larger resolutions, but it's way more comfortable to read. Methods within class synopsis (eg the methods listed here http://php.net/manual/en/class.intltimezone.php) may continue to stay on one line each.

@morrisonlevi
Copy link
Owner

morrisonlevi commented Nov 10, 2016

If we use the right markup I think we can perhaps do this dynamically in the browser based on browser width. This could be a really nice enhancement. Good idea.

It might need JavaScript to really work nicely; however this is exactly the sort of thing I don't mind using JavaScript for.

@Wes0617
Copy link
Collaborator Author

Wes0617 commented Nov 10, 2016

with proper markup we don't even need javascript, just plain css
edit: perhaps js will be needed, but not a lot of it.

@morrisonlevi
Copy link
Owner

I think it would need JavaScript to properly do the wrapping because of two reasons:

  • Each parameter section is indented only if it wraps
  • If it wraps then all parameter sections should wrap

@kelunik
Copy link
Collaborator

kelunik commented Nov 11, 2016

@Netmosfera Please only for very long lines, not for all. For a small parameter list, it's harder to read that way.

@Sobak
Copy link

Sobak commented Dec 14, 2016

-1 from me, sorry. I agree with @kelunik - that's actually makes it harder to read.

@Wes0617
Copy link
Collaborator Author

Wes0617 commented Dec 16, 2016

okay, so only for lines that wrap?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants