Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply lazy_required when inheriting from existing attributes #1

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Apply lazy_required when inheriting from existing attributes #1

wants to merge 16 commits into from

Commits on Jun 12, 2020

  1. Proof of concept: apply LazyRequired when cloning and inheriting 

    attributes.
    @skington
    skington committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    3231cc9 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2020

  1. Add comments to the bare-bones test that was provided as part of the 

    initial bug report.
    @skington
    skington committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    c4ee29b View commit details
    Browse the repository at this point in the history

  2. Get rid of algebraic variable names.

    @skington
    skington committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    4370351 View commit details
    Browse the repository at this point in the history

  3. Clarification: MooseX::LazyRequire doesn't add a trait to attributes.

    @skington
    skington committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    7bb448e View commit details
    Browse the repository at this point in the history

  4. Make sure that you can override the required option if you disable 

    lazy_required.
    @skington
    skington committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    5f76509 View commit details
    Browse the repository at this point in the history

  5. Test that we can say "not lazy-required, but still lazy".

    @skington
    skington committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    c1ed89e View commit details
    Browse the repository at this point in the history

  6. If you disable lazy_required but don't provide an alternative default, 

    and the type you're using doesn't allow undef, you're in a world of
hurt.
    @skington
    skington committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    64078b8 View commit details
    Browse the repository at this point in the history

  7. Document the limitations of saying lazy_required and then "wait, never 

    mind".
    @skington
    skington committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    fea0aa7 View commit details
    Browse the repository at this point in the history

  8. Whitespace shenanigans.

    @skington
    skington committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    8dff0fe View commit details
    Browse the repository at this point in the history

  9. Don't confuse explicitly saying lazy_required => 0 and not mentioning 

    lazy_required at all. All a class needs to do is say
 use MooseX::LazyRequire;
and the clone_and_inherit_options method of Moose::Meta::Attribute
will be wrapped - for *all* attributes.
    @skington
    skington committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    98fda82 View commit details
    Browse the repository at this point in the history

  10. More whitespace shenanigans.

    @skington
    skington committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    2fbb5b6 View commit details
    Browse the repository at this point in the history

  11. Typo.

    @skington
    skington committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    86307d9 View commit details
    Browse the repository at this point in the history

  12. Actually mention what changed.

    @skington
    skington committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    b2d5363 View commit details
    Browse the repository at this point in the history

  13. Documentation fix: we're overriding an attribute, not replacing it.

    @skington
    skington committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    32d032e View commit details
    Browse the repository at this point in the history

  14. Trivial documentation fix.

    @skington
    skington committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    878c6be View commit details
    Browse the repository at this point in the history

  15. Move this test to a slightly more logical place.

    @skington
    skington committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    54eb467 View commit details
    Browse the repository at this point in the history