Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make error messages for setting with a reader more awesome #106

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Make error messages for setting with a reader more awesome #106

wants to merge 6 commits into from

Commits on Jul 15, 2015

  1. Make error messages for setting with a reader more awesome 

    If you try and set an attribute with the reader accessor and a different named writer accessor exists the error message now tells you the name of the writer
    @2shortplanks
    2shortplanks committed Jul 15, 2015
    Configuration menu
    Copy the full SHA
    5d3c0f5 View commit details
    Browse the repository at this point in the history

  2. update changes to reflect more awesome error messages

    @2shortplanks
    2shortplanks committed Jul 15, 2015
    Configuration menu
    Copy the full SHA
    c5a89be View commit details
    Browse the repository at this point in the history

  3. test inline accessor changes too

    @2shortplanks
    2shortplanks committed Jul 15, 2015
    Configuration menu
    Copy the full SHA
    5309ee9 View commit details
    Browse the repository at this point in the history

  4. Don't suggest private writer names in error message

    @2shortplanks
    2shortplanks committed Jul 15, 2015
    Configuration menu
    Copy the full SHA
    f879816 View commit details
    Browse the repository at this point in the history

  5. Clearer comments

    @2shortplanks
    2shortplanks committed Jul 15, 2015
    Configuration menu
    Copy the full SHA
    3238e2b View commit details
    Browse the repository at this point in the history

  6. Reword the changes for improved read-only accessor error messages 

    Change the changes to reflect that private accessors are no longer named
    @2shortplanks
    2shortplanks committed Jul 15, 2015
    Configuration menu
    Copy the full SHA
    512efcc View commit details
    Browse the repository at this point in the history