Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up a way that the tip of a pull request is deployed to github pages #26

Closed
moorepants opened this issue Feb 24, 2022 · 2 comments
Closed

Comments

@moorepants
Copy link
Owner

One way to do this is to make a new directory structure that has:

https://moorepants.github.io/learn-multibody-dynamics/pull-requests/branch-name

Then each pull request could build the version of the website and deploy to a subdirectory. When the pull request is merged, that directory should be deleted on gh-pages.

@moorepants
Copy link
Owner Author

I got something mostly working in 2246b1e but the result doesn't display the JS external libs, see: htmlpreview/htmlpreview.github.com#109

This was also suggested:

https://docs.netlify.com/site-deploys/deploy-previews/

@moorepants
Copy link
Owner Author

This now works. I forked htmlpreview and applied the pr to let external JS run. There is now an action that manages the commenting and branch creation: #27 the only issue is that the branch isn't deleted on merge. That has to be done manually, but can be fixed later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant