Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dev_flashbox flags #371

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Missing dev_flashbox flags #371

merged 1 commit into from
Dec 21, 2023

Conversation

fgamundi
Copy link
Contributor

Fixes the unexpected behavior when running Moonwall test suite dev_flashbox, addressed by --reserved-only

@fgamundi fgamundi added B0-silent Changes should not be mentioned in any release notes not-breaking Does not need to be mentioned in breaking changes labels Dec 21, 2023
@tmpolaczyk
Copy link
Contributor

For the record, the issue was that moonwall spawns multiple nodes at once, and without the --reserved-only flag those nodes connected to each other. --dev already implies this flag, that's why the other tests work. Thank you for the detective work @fgamundi! I already tried this locally and it works. (I got a timeout error once but that's a known issue)

Copy link
Contributor

Coverage Report

(master)

@@                  Coverage Diff                  @@
##           master   fg-flashbox-flags      +/-   ##
=====================================================
- Coverage   75.95%              75.94%   -0.01%     
  Files          97                  97              
  Lines       24332               24332              
=====================================================
- Hits        18481               18477       -4     
+ Misses       5851                5855       +4     
Files Changed Coverage
/pallets/inflation-rewards/src/lib.rs 90.91% (-2.27%) 🔽
/pallets/registrar/src/lib.rs 91.93% (-0.25%) 🔽

Coverage generated Thu Dec 21 14:43:53 UTC 2023

@fgamundi fgamundi merged commit 92912d6 into master Dec 21, 2023
31 checks passed
@fgamundi fgamundi deleted the fg-flashbox-flags branch December 21, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants