Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pallet relay storage roots #370

Merged
merged 11 commits into from
Jan 17, 2024
Merged

Conversation

tmpolaczyk
Copy link
Contributor

@tmpolaczyk tmpolaczyk commented Dec 19, 2023

Adds a pallet_relay_storage_roots. This pallet stores the latest MaxStorageRoots relay storage roots, which can be used to verify state proofs against an old state of the relay chain.

See also https://github.com/moondance-labs/moonkit/pull/1/files and Moonsong-Labs/moonkit#18

@tmpolaczyk
Copy link
Contributor Author

tmpolaczyk commented Dec 20, 2023

Container chains won't compile because dancekit depends on moonkit, and I didn't make a new branch in dancekit. Will fix this after moonkit PR is merged I guess Fixed

@girazoki
Copy link
Collaborator

girazoki commented Jan 8, 2024

A few requested changes but otherwise looks good! I guess we should propose to dancekit or moonkit directly instead

@girazoki
Copy link
Collaborator

girazoki commented Jan 8, 2024

Looks good, but see the other PR as I made some comments there

@tmpolaczyk tmpolaczyk added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes not-breaking Does not need to be mentioned in breaking changes labels Jan 16, 2024
@tmpolaczyk tmpolaczyk changed the title Tomasz pallet storage roots Add pallet relay storage roots Jan 16, 2024
@tmpolaczyk tmpolaczyk marked this pull request as ready for review January 16, 2024 10:54
Copy link
Contributor

github-actions bot commented Jan 16, 2024

Coverage Report

(master)

@@                       Coverage Diff                       @@
##           master   tomasz-pallet-storage-roots      +/-   ##
===============================================================
+ Coverage   75.97%                        75.99%   +0.02%     
  Files          98                            98              
+ Lines       24568                         24576       +8     
===============================================================
+ Hits        18665                         18675      +10     
- Misses       5903                          5901       -2     
Files Changed Coverage
/pallets/registrar/src/lib.rs 92.18% (+0.25%) 🔼
/pallets/services-payment/src/lib.rs 84.56% (+0.67%) 🔼
/runtime/dancebox/src/lib.rs 81.31% (+0.08%) 🔼
/runtime/flashbox/src/lib.rs 43.93% (+0.31%) 🔼

Coverage generated Tue Jan 16 18:33:14 UTC 2024

@girazoki girazoki added breaking Needs to be mentioned in breaking changes and removed not-breaking Does not need to be mentioned in breaking changes labels Jan 17, 2024
@girazoki
Copy link
Collaborator

LGTM!

@tmpolaczyk tmpolaczyk merged commit fd9e0d0 into master Jan 17, 2024
32 checks passed
@tmpolaczyk tmpolaczyk deleted the tomasz-pallet-storage-roots branch January 17, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants