-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pallet relay storage roots #370
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A few requested changes but otherwise looks good! I guess we should propose to dancekit or moonkit directly instead |
Looks good, but see the other PR as I made some comments there |
tmpolaczyk
added
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
not-breaking
Does not need to be mentioned in breaking changes
labels
Jan 16, 2024
tmpolaczyk
changed the title
Tomasz pallet storage roots
Add pallet relay storage roots
Jan 16, 2024
Coverage Report@@ Coverage Diff @@
## master tomasz-pallet-storage-roots +/- ##
===============================================================
+ Coverage 75.97% 75.99% +0.02%
Files 98 98
+ Lines 24568 24576 +8
===============================================================
+ Hits 18665 18675 +10
- Misses 5903 5901 -2
|
girazoki
added
breaking
Needs to be mentioned in breaking changes
and removed
not-breaking
Does not need to be mentioned in breaking changes
labels
Jan 17, 2024
girazoki
approved these changes
Jan 17, 2024
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
breaking
Needs to be mentioned in breaking changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
pallet_relay_storage_roots
. This pallet stores the latestMaxStorageRoots
relay storage roots, which can be used to verify state proofs against an old state of the relay chain.See also https://github.com/moondance-labs/moonkit/pull/1/files and Moonsong-Labs/moonkit#18