migration for hold identifier #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Master coverage: 74.46% |
nanocryk
requested changes
Sep 7, 2023
| for (account_id, holds) in stored_data { | ||
| let mut new_holds = vec![]; | ||
|
|
||
| for hold in holds { |
There was a problem hiding this comment.
Would that turn all holds into PooledStake holds? No other pallets perform holds?
There was a problem hiding this comment.
we only have one hold type yes. The problem if I evaluate the hold type is that I still need to convert the rest of the hold identifiers to something and that something right now is only PooledStake
nanocryk
approved these changes
Sep 7, 2023
girazoki
added a commit
that referenced
this pull request
Sep 7, 2023
* migration for hold identifier * clean warning * tests * updated interfaces
rimbi
pushed a commit
to rimbi/tanssi
that referenced
this pull request
Oct 17, 2023
* migration for hold identifier * clean warning * tests * updated interfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates hold identifier from [u8; 8] to a proper enum holdReason