-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark generic XCM instructions #248
Conversation
Master coverage: 74.51% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Note this is only generic instructions, so I would add that to the PR title. Do we envision how can we use them in templates as well?
@girazoki if we need to implement these benchmarks for templates and Tanssi at the same time, we could build a So, is it planned that the templates and Tanssi use the same weights from now on? If that's the case, would you like me to apply the |
lets for now keep it separate. We will evaluate later |
Adds benchmarking for XCM generic instructions of
pallet_xcm_benchmarks::generic
.Also refactors benchmarks config inside the
dancebox
runtime. Individual calls tolist_benchmark!
andadd_benchmark!
macros were replaced by a single module calledbenches
that contains all the desired pallets to be benchmarked in a cleaner way, making use of thedefine_benchmarks!
macro.