Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark generic XCM instructions #248

Merged
merged 10 commits into from
Sep 8, 2023
Merged

Conversation

Agusrodri
Copy link
Contributor

Adds benchmarking for XCM generic instructions of pallet_xcm_benchmarks::generic.

Also refactors benchmarks config inside the dancebox runtime. Individual calls to list_benchmark! and add_benchmark! macros were replaced by a single module called benches that contains all the desired pallets to be benchmarked in a cleaner way, making use of the define_benchmarks! macro.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Master coverage: 74.51%
Coverage generated "Fri Sep 8 16:11:20 UTC 2023":
https://d3gkbsry1ehhqi.cloudfront.net/tanssi-coverage/pulls/248/index.html
Pull coverage: 71.92%

Copy link
Collaborator

@girazoki girazoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Note this is only generic instructions, so I would add that to the PR title. Do we envision how can we use them in templates as well?

@Agusrodri
Copy link
Contributor Author

Agusrodri commented Sep 8, 2023

@girazoki if we need to implement these benchmarks for templates and Tanssi at the same time, we could build a common package and put the weights module inside it, but for it to be actually useful we should ensure that we want to use the same weights in templates and Tanssi all the time. Otherwise, if we start needing specific weights for each runtime, this module inside the common package will become useless.

So, is it planned that the templates and Tanssi use the same weights from now on? If that's the case, would you like me to apply the common package in this PR or in a separate one?

@Agusrodri Agusrodri changed the title Benchmark XCM instructions Benchmark generic XCM instructions Sep 8, 2023
@girazoki
Copy link
Collaborator

girazoki commented Sep 8, 2023

lets for now keep it separate. We will evaluate later

@Agusrodri Agusrodri merged commit 35e1a27 into master Sep 8, 2023
22 checks passed
@Agusrodri Agusrodri deleted the agustin-xcm-benchmarks branch September 8, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants