-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manage XCM through maintenance mode filters #243
Conversation
Master coverage: 72.05% |
test/suites/dev-frontier-template/test-maintenance/test-maintenance-xcm-normal-filter.ts
Outdated
Show resolved
Hide resolved
@@ -520,10 +522,20 @@ impl pallet_utility::Config for Runtime { | |||
type WeightInfo = pallet_utility::weights::SubstrateWeight<Runtime>; | |||
} | |||
|
|||
pub struct XcmExecutionManager; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am starting to think we should move this into xcm-pritmitives
TODO: add tests for DMP and general XCM messages in maintenance mode. Edit: the XCM queue works as expected (after disabling maintenance mode the queued message is automatically executed in the corresponding block). On the other hand, that is not the case with DMP queue, which is failing only on frontier template (the queued message is not being automatically executed after disabling maintenance mode). I'm investigating the issue. Second edit: (solved) Explanation of the problemThe issue was related to fixed XCM weights and their impact inside the The Due to this conflict, the incoming DMP message is put inside the To solve this, a proper solution would be to add a extrinsic to the |
@Agusrodri can you merge master in? Also we can merge as is but I will create an issue to move these into their proper primitives crates in moonkit |
This PR adds the possibility of managing XCM functionalities through maintenance mode filters.
The following changes were applied to frontier and simple templates, and also to the dancebox runtime:
MaintenanceFilter
will forbid any call topolkadotXcm
pallet.xcm-support
feature was added topallet-maintenance-mode
, alongside with the custom implementations ofXcmExecutionManager
,NormalDmpHandler
andMaintenanceDmpHandler
types.