Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XCMP #311

Closed
wants to merge 14 commits into from
Closed

XCMP #311

wants to merge 14 commits into from

Conversation

4meta5
Copy link
Contributor

@4meta5 4meta5 commented Mar 30, 2021

What does it do?

Resurrects #263 using the most recent set of dependencies.

Steps for a parachain -> parachain transfer.

  • open channel on the relay chain (using paraSudoWrapper for now)
  • call xtransfer method to make the transfer

We have NOT yet successfully opened a channel on the relay chain, which is required for the xtransfer function.

What important points reviewers should know?

Instructions for running polkadot-launch tests

  1. Compile the code. First the local node and then the correct polkadot version in the parent repo of the local moonbeam repo.

  2. Install local polkadot-js types. Enter moonbeam-types-bundle and run npm i.

  3. enter tools and run yarn run moonbeam-xcmp

Here is the output from running these commands. Both parachains are registered successfully. The paraSudoWrapper call to open the channel is failing. The error index points to OpenHrmpChannelInvalidRecipient in polkadot::parachains::hrmp so we need to check that the parachain registration is persisting. I have a feeling that the ParaLifeCycle is onboarding so that's why the recipient isn't a valid para yet...

ALL PARACHAINS REGISTERED
moonbeam launch launched
++ Sanity Checks Passed for Relay Chain and Both Parachains
Current status is Ready
Current status is {"broadcast":["12D3KooWK5DWVqzHE8YbBhEkUiLWRAtiLn3dNBRYj4ysYDVNziSh","12D3KooWPiHvhmUh1gKRrZS5F9gKHF9Qz69S8FmTaQBuuGJmSQan","12D3KooWC9NDBe5xerMRaftALxS4RvYLnxAP5FHatPMS5P3NWfJC","12D3KooWHnjqnkmAd25kzcotEEeUtxQczegRryLucAHM4fU2i3r8"]}
Current status is {"inBlock":"0x06f2f8fe7ac4a5afad17c82ff18b3c7aa477693d257d2b65e25cc93657939802"}
Transaction included at blockHash 0x06f2f8fe7ac4a5afad17c82ff18b3c7aa477693d257d2b65e25cc93657939802
Current status is {"finalized":"0x06f2f8fe7ac4a5afad17c82ff18b3c7aa477693d257d2b65e25cc93657939802"}
Transaction finalized at blockHash 0x06f2f8fe7ac4a5afad17c82ff18b3c7aa477693d257d2b65e25cc93657939802
	' {"applyExtrinsic":2}: sudo.Sudid:: [{"err":{"module":{"index":23,"error":1}}}]
	' {"applyExtrinsic":2}: system.ExtrinsicSuccess:: [{"weight":11000,"class":"Operational","paysFee":"Yes"}]
api call resolved
expectedchannel Option {
  registry: TypeRegistry { createdAtHash: undefined },
  createdAtHash: undefined
} null
Current status is Ready
^CSIGINT test
exit index test

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

Checklist

  • Does it require a purge of the network?
  • You bumped the runtime version if there are breaking changes in the runtime ?
  • Does it require changes in documentation/tutorials ?

@4meta5
Copy link
Contributor Author

4meta5 commented Apr 9, 2021

TODO: must wait until both parachains are fully registered to open the channel (2 sessions after parachain registration is called => 4 hours)

Blocked until we add the parachain registration to paras genesis cc @JoshOrndorff (because no test is going to take 4 hours)

@JoshOrndorff
Copy link
Contributor

This is the core of my idea about how to register paras from genesis. https://github.com/paritytech/polkadot/blob/76bfd9fa9c828155eb46cf09eb14becd3058408a/runtime/parachains/src/paras.rs#L306

Ultimately it should go into polakdot-launch paritytech/polkadot-launch#66

But we should be able to use it manually in the meantime.

@4meta5
Copy link
Contributor Author

4meta5 commented Jun 8, 2021

so stale, I'd just start from scratch with any XCMP config

@4meta5 4meta5 closed this Jun 8, 2021
@4meta5 4meta5 deleted the amar-xc2 branch February 22, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants