Test XCM transfer and pay fees with foreign asset #3047
+306
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzamontiel
added
B0-silent
WASM runtime size check:Compared to target branchMoonbase runtime: 2260 KB (no changes) ✅ Moonbeam runtime: 2232 KB (no changes) ✅ Moonriver runtime: 2224 KB (no changes) ✅ Compared to latest release (runtime-3300)Moonbase runtime: 2260 KB (+232 KB compared to latest release) Moonbeam runtime: 2232 KB (+236 KB compared to latest release) Moonriver runtime: 2224 KB (+232 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master gonza/test-xcm-transfer-and-pay-fees +/- ##
========================================================================
+ Coverage 74.81% 79.00% +4.19%
- Files 369 303 -66
- Lines 94137 88208 -5929
========================================================================
- Hits 70421 69685 -736
- Misses 23716 18523 -5193
|
Agusrodri
reviewed
Nov 20, 2024
test/suites/dev/moonbase/test-xcm-v4/test-xcm-evm-fee-with-origin-token.ts
Outdated
Show resolved
Hide resolved
| }, | ||
| }); | ||
|
|
||
| async function registerAndFundAsset( |
There was a problem hiding this comment.
I think we should move this function to helpers folder. I would also suggest renaming it to registerAndFundOldAsset.
Also, it would be nice to add a small comment explaining why the function was created.
test/suites/dev/moonbase/test-xcm-v4/test-xcm-evm-fee-with-origin-token.ts
Outdated
Show resolved
Hide resolved
| }; | ||
|
|
||
| /** | ||
| * We are going to test the following scenario: |
gonzamontiel
changed the title
gonzamontiel
changed the title
…gin-token.ts Co-authored-by: Agustín Rodriguez <[email protected]>
…gin-token.ts Co-authored-by: Agustín Rodriguez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We test that an account in some parachain, can transfer some foreign assets to an account in Moonbeam, paying in another foreign asset. So that they don't need to buy GLMR for buying time for the execution.