[frontier] Add support for PoV gas refunding #3036
Conversation
| @@ -88,7 +90,7 @@ describeSuite({ | |||
| ], | |||
| privateKey: BALTATHAR_PRIVATE_KEY, | |||
| rawTxOnly: true, | |||
| gas: expectedGas, | |||
| gas: 91_088n, | |||
There was a problem hiding this comment.
Note: this call fails with OOG if we use a gas_limit lower than this number (which is the entire pov_gas without refunding), but the actual gas_used is the expected one (54_168n) and it's correct.
@RomarQ @ahmadkaouk any clue of what could be happening? I guess that the remaining gas should be refunded to the user after the execution, but not sure why we must indicate 91_088n here. Instead, a gas limit of 54_168n should be enough to cover all the transaction cost.
There was a problem hiding this comment.
At the end this is expected, as we still count for the worst case scenario at the moment of estimating.
WASM runtime size check:Compared to target branchMoonbase runtime: 2260 KB (no changes) ✅ Moonbeam runtime: 2232 KB (no changes) ✅ Moonriver runtime: 2228 KB (no changes) ✅ Compared to latest release (runtime-3300)Moonbase runtime: 2260 KB (+232 KB compared to latest release) Moonbeam runtime: 2232 KB (+236 KB compared to latest release) Moonriver runtime: 2228 KB (+236 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master agustin-frontier-pov-reclaim +/- ##
===============================================================
Coverage 79.00% 79.00% 0.00%
Files 303 303
Lines 88208 88208
===============================================================
Hits 69685 69685
Misses 18523 18523
|
RomarQ
added
B7-runtimenoteworthy
|
I tested a live transaction (with lazy fork) from BeamSwap using this PR. |
|
@Agusrodri I can see the ref_time of weight (v2) jumps from 93M to 7M. Is that normal ? |
Not sure if this is normal to be honest. From my understanding the refund should only take place in the pov size right? Will need to investigate. |
|
After more consideration, it is expected to also be lower. For Ethereum transaction, the weight (ref_time) is computed from the gas cost, using a gas to weight ratio. The gas being lower (due to PoV) the ref_time is lower being lower. So all good |
No description provided.