New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Course short names causing "Error code: invalidadminsettingname !!" #21

Closed

erazorbg opened this issue Jun 14, 2019 · 1 comment

Contributor

erazorbg commented Jun 14, 2019

This code in settings PHP causes an error when the course short name includes characters that are invalid for a setting name.

auth/settings.php

Lines 228 to 233 in 581955d

    
           $name = 'auth_saml/role_mapping_'.strtolower($role->shortname); 
        
           $title = $role->shortname; 
        
           $description = ''; 
        
           $default = null; 
        
           $setting = new admin_setting_configtext_trim($name, $title, $description, $default, PARAM_RAW); 
        
           $settings->add($setting);

Contributor Author

erazorbg commented Jun 14, 2019

Sorry didn't realize this was already reported in #14, closing it.

erazorbg closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment