Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should flowchart say "Continue processing request" where is says "Not a valid CORS request"? #158

Open
nickform-ost opened this issue Jun 15, 2021 · 0 comments

Comments

@nickform-ost
Copy link

First of all, thanks for this very useful resource.

This is really just a question. Since the flowchart is described as a "flowchart for implementing CORS support" I think it would be useful if all terminals contained actions rather than conclusions. When a request is not a CORS request, the server should just process it without adding any of the CORS headers. Thus, wouldn't it make sense if the "No" branch of the first decision connected to "Continue processing the response"?

As for the other red terminal "Not a valid preflight request", perhaps it would be more helpful to say "return 400 with a body describing the problem"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant