From 1e918adb2ad4e9c678219630dc2cf9d4b9ef46c1 Mon Sep 17 00:00:00 2001 From: Nathan Xu Date: Sun, 20 Oct 2024 23:09:45 -0400 Subject: [PATCH] change 'isShortSrvHost' to 'srvHostHasLessThanThreeParts' and remove redundant code comment as per code review comment --- .../main/com/mongodb/internal/dns/DefaultDnsResolver.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/driver-core/src/main/com/mongodb/internal/dns/DefaultDnsResolver.java b/driver-core/src/main/com/mongodb/internal/dns/DefaultDnsResolver.java index d48a38d009..2f57c6ddf7 100644 --- a/driver-core/src/main/com/mongodb/internal/dns/DefaultDnsResolver.java +++ b/driver-core/src/main/com/mongodb/internal/dns/DefaultDnsResolver.java @@ -70,9 +70,9 @@ public List resolveHostFromSrvRecords(final String srvHost, final String List srvHostParts = asList(srvHost.split("\\.")); String srvHostDomain; - boolean isShortSrvHost = srvHostParts.size() < 3; - if (isShortSrvHost) { - srvHostDomain = srvHost; // when dot separated parts less than 3, domain name is the host per se + boolean srvHostHasLessThanThreeParts = srvHostParts.size() < 3; + if (srvHostHasLessThanThreeParts) { + srvHostDomain = srvHost; } else { srvHostDomain = srvHost.substring(srvHost.indexOf('.') + 1); } @@ -89,7 +89,7 @@ public List resolveHostFromSrvRecords(final String srvHost, final String for (String srvRecord : srvAttributeValues) { String[] split = srvRecord.split(" "); String resolvedHost = split[3].endsWith(".") ? split[3].substring(0, split[3].length() - 1) : split[3]; - if (isShortSrvHost && resolvedHost.equals(srvHost)) { + if (srvHostHasLessThanThreeParts && resolvedHost.equals(srvHost)) { throw new MongoConfigurationException( format("The SRV host name '%s' has less than three parts and the resolved host '%s' is identical.", srvHost, resolvedHost)