Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Biolink merge brings in LinkML types #37

Closed
caufieldjh opened this issue May 26, 2023 · 3 comments · Fixed by #94
Closed

Biolink merge brings in LinkML types #37

caufieldjh opened this issue May 26, 2023 · 3 comments · Fixed by #94
Labels
bug Something isn't working

Comments

@caufieldjh
Copy link
Member

Describe the bug

See monarch-initiative/monarch-ingest#468 (comment)

Biolink imports linkml types (see https://github.com/biolink/biolink-model/blob/master/biolink-model.ttl) but these types remain in Phenio, hence they become nodes in KG-Phenio.
They don't serve any purpose here.

@caufieldjh caufieldjh added the bug Something isn't working label May 26, 2023
@matentzn
Copy link
Member

So how will you avoid them being nodes? the moment you say:

MONDO:123 bl:category bl:Disease

That moment bl:Disease will become a node, right?

@caufieldjh
Copy link
Member Author

It does, and that's a separate (but related) issue - in this case it's that all children of bl:named_thing have slots with types defined by linkml:types, so we essentially need the base version of whatever a linkml schema is, except with all the roots for namespaces in Phenio like MONDO

@matentzn
Copy link
Member

Maybe easier for now to just extract a filter module from the linkml schema, only including the exact terms that are in there, and only configuring certain properties to be included?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants