Update Trimethylaminuria Classification #8385
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #8062 - Changed definition - Removed Synonyms that were for primary term - Added GH tracker to both terms
sabrinatoro
reviewed
Nov 14, 2024
| @@ -251650,6 +251648,7 @@ relationship: curated_content_resource https://search.clinicalgenome.org/kb/cond | |||
| relationship: disease_has_basis_in_disruption_of GO:0047865 {source="OMIM:602079"} ! dimethylglycine dehydrogenase activity | |||
| relationship: excluded_from_qc_check http://purl.obolibrary.org/obo/mondo/sparql/qc/general/qc-single-child.sparql | |||
| property_value: IAO:0000233 "https://github.com/monarch-initiative/mondo/issues/3448" xsd:anyURI | |||
| property_value: IAO:0000233 "https://github.com/monarch-initiative/mondo/issues/8062" xsd:string | |||
There was a problem hiding this comment.
This should be a xsd:URI.
sabrinatoro
reviewed
Nov 14, 2024
| @@ -423292,6 +423291,7 @@ relationship: excluded_subClassOf MONDO:0019189 {source="Orphanet:468726", sourc | |||
| property_value: IAO:0000233 "https://github.com/monarch-initiative/mondo/issues/3448" xsd:anyURI | |||
| property_value: IAO:0000233 "https://github.com/monarch-initiative/mondo/issues/4521" xsd:anyURI | |||
| property_value: IAO:0000233 "https://github.com/monarch-initiative/mondo/issues/4985" xsd:anyURI | |||
| property_value: IAO:0000233 "https://github.com/monarch-initiative/mondo/issues/8062" xsd:string | |||
There was a problem hiding this comment.
This is very weird... It is a "term" but it has the x-ref... I will take a look in the obo file
|
The changes here are fine, but the changes in the diff make me nervous. I will recreate a new PR with these changes, just for my peace of mind. |
sabrinatoro
added a commit
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8062