Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to fix mondo qc errors from synonym sync pipeline #8402

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

twhetzel
Copy link
Collaborator

closes #8332

see ticket for reason for this PR

@@ -461123,7 +461120,7 @@ synonym: "pituitary-dependent Cushing's disease" EXACT [doi:10.1093/jama/9780195
xref: DOID:3946 {source="EFO:1001110", source="MONDO:equivalentTo"}
xref: EFO:1001110 {source="MONDO:equivalentTo", source="MONDO:EFO"}
xref: GARD:19699 {source="MONDO:GARD"}
xref: ICD10CM:E24.0 {source="EFO:1001110", source="MONDO:equivalentTo", source="Orphanet:99892/ntbt", source="DOID:3946", source="Orphanet:99892", source="MONDO:directSiblingOf"}
xref: ICD10CM:E24.0 {source="EFO:1001110", source="MONDO:equivalentTo", source="Orphanet:99892/ntbt", source="DOID:3946", source="Orphanet:99892"}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed incorrect source="MONDO:directSiblingOf, the source="MONDO:equivalentTo" remains

@@ -82425,7 +82424,6 @@ xref: MEDGEN:308434 {source="MONDO:equivalentTo", source="MONDO:MEDGEN"}
xref: MESH:D001170 {source="DOID:813", source="MONDO:equivalentTo"}
xref: NANDO:2200437 {source="MONDO:NANDO", source="https://orcid.org/0000-0003-0011-764X", source="https://orcid.org/0000-0002-0170-9172"}
xref: NCIT:C26699 {source="MONDO:equivalentTo"}
xref: NCIT:C26700 {source="DOID:813", source="MONDO:directSiblingOf"}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NCIT:C26700 is infective arthritis and is a parent of bacterial arthritis so this is not correct that NCIT:C26700 is a sibling of MONDO:0004471 'bacterial arthritis'.

@twhetzel twhetzel marked this pull request as draft November 15, 2024 02:36
@twhetzel twhetzel marked this pull request as ready for review November 15, 2024 02:41
Copy link
Collaborator

@sabrinatoro sabrinatoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.
I am approving and merging!

@sabrinatoro sabrinatoro merged commit e8345cd into master Nov 15, 2024
1 check passed
@sabrinatoro sabrinatoro deleted the issue-8332 branch November 15, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix inconsistencies in xrefs related to errors in Synonym sync
2 participants