Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grouping: omimFormerly, omimIncluded, & includedEntryInOMIM #715

Open
3 of 7 tasks
joeflack4 opened this issue Dec 2, 2024 · 2 comments
Open
3 of 7 tasks

Grouping: omimFormerly, omimIncluded, & includedEntryInOMIM #715

joeflack4 opened this issue Dec 2, 2024 · 2 comments
Assignees

Comments

@joeflack4
Copy link
Contributor

joeflack4 commented Dec 2, 2024

Overview

Sub-tasks

  • "Included" Decide if we want just want 1 property or 2
  • Decide implementation of omimFormerly and omimIncluded
    • a. Joe and Nico think best as synonym types
    • b. We're currently (tentatively?) using them as annotation properties.
  • Remove redundant rdf:comments?
    • rdfs:comment "This term has one or more labels that end with ', INCLUDED'."

Sub-issues

@matentzn
Copy link
Member

matentzn commented Dec 4, 2024

Just to reiterate:

[Term]
id: NI:CO
synonym: "Big G" EXACT ["MONDO:IncludedEntryInOMIM"]

Is something very different from

[Term]
id: NI:CO
synonym: "Big G" OMIM_INCLUDED EXACT []

Do not mix these two things up! The first case is source evidence. The second case is a synonym type property!

@joeflack4
Copy link
Contributor Author

joeflack4 commented Dec 16, 2024

Nico says this usage is bad, e.g.:

  • TERM MONDO:omimIncluded true
  • TERM MONDO:includedEntryInOMIM true

Do this:

  • synonym: "Big G" EXACT ["MONDO:IncludedEntryInOMIM"]
    • Should be an oboInOwl:source property

Want to do this way (using omim repo's new functional code):

            add_triple_and_optional_annotations(graph, omim_uri, oboInOwl.hasExactSynonym, title,
                [oboInOwl.source, Literal('MONDO:includedEntryInOMIM')])

            add_triple_and_optional_annotations(graph, omim_uri, oboInOwl.hasExactSynonym, title,
                [oboInOwl.hasSynonymType, URIRef(MONDONS['omim_included'])])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants