Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update phenio node property filter #309

Open
kevinschaper opened this issue Aug 3, 2022 · 2 comments
Open

Update phenio node property filter #309

kevinschaper opened this issue Aug 3, 2022 · 2 comments
Assignees

Comments

@kevinschaper
Copy link
Member

It's a little awkward that we're filtering here, but won't need to later. Still, it's worth expanding our very short column list for phenio nodes as soon as possible, since we're missing obsolete/deprecated.

Pulling from monarch-initiative/phenio#13, we should keep the biolink equivalent properties for:

"alternative_term"
"broadMatch"
"category"
"closeMatch"
"contributor"
"created_by"
"creator"
"database_cross_reference"
"definition"
"deprecated"
"exactMatch"
"has_broad_synonym"
"has_exact_synonym"
"has_narrow_synonym"
"has_obsolescence_reason"
"has_related_synonym"
"in_subset"
"label"
"narrowMatch"
"never_in_taxon"
"term_replaced_by"
"term_tracker_item"

Probably the first task would be to translate these to biolink properties, is that something you can do pretty easily @RichardBruskiewich?

@monicacecilia
Copy link

Dear @RichardBruskiewich, are these now Biolink properties? Has this been addressed?

@sierra-moxon 👀 👆 FYI.

@RichardBruskiewich
Copy link
Collaborator

@kevinschaper @sierra-moxon (cc: @monicacecilia), I've attempted a Biolink mapping of the above terms. There are a few gaps and tricky mappings (to linkML rather than Biolink) so perhaps, @sierra-moxon

Monarch_Ingest_Issue_309.pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants