If skip_blank_lines is False in CSVReader, garbage data is read out in all cases

[ptgolden]

The second clause here should be elif not row or elif row == [].

koza/src/koza/io/reader/csv_reader.py

Lines 126 to 130 in fceafe5

	if self.skip_blank_lines:
	while not row:
	row = next(self.reader)
	else:
	row = ['NaN' for _ in range(len(self._header))]

Since it's not, if skip_blank_lines=False is passed to the reader, then in all cases, every value read will be 'NaN' for str types, nan for float types, and raise an error for int types.

I'm surprised no one has ever run into this-- it suggests that no one has ever used the non-default option of skip_blank_lines.

[ptgolden]

It looks like that clause was introduced in 80cf068, which means 3 years and no reports of output consisting solely of "NaN"

[ptgolden]

skip_blank_lines is never set to false, because it's not passed to the CSVReader constructor when reading a source:

koza/src/koza/model/source.py

Lines 38 to 48 in fceafe5

	CSVReader(
	resource_io,
	name=config.name,
	field_type_map=config.field_type_map,
	delimiter=config.delimiter,
	header=config.header,
	header_delimiter=config.header_delimiter,
	header_prefix=config.header_prefix,
	comment_char=self.config.comment_char,
	row_limit=self.row_limit,
	)

Can we remove this option? Either blank lines can always be skipped (which is the current behavior), or they can cause an error (due to being malformed CSV).