Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRANSLOCATION #368

Closed
pnrobinson opened this issue Dec 1, 2024 · 4 comments
Closed

TRANSLOCATION #368

pnrobinson opened this issue Dec 1, 2024 · 4 comments
Assignees

Comments

@pnrobinson
Copy link
Member

We should probably support translocation -- the fact that somebody has a clinical picture of disease and a translocation that disrupts the corresponding gene is taken to be evidence that the molecular mechanism of the translocation is an ABLATION of the gene.
In any case, the error message is very alarming:
https://github.com/monarch-initiative/gpsea-cs/blob/develop/notebooks/SATB2/SATB2_gpsea.ipynb
But in practice the user can ignore it in this case -- but people will think it is irrevocably broken.
It would be better to have a message in RED

We removed 6 cases from analysis because the variant type TRANSLOCATION is not supported. 150 cases remain.

@pnrobinson
Copy link
Member Author

This is an example phenopacket from SATB2, PMID_31021519_Case1fromBreweretal.json, it has a translocation and should be included in our GPSEA cohort.

@ielis ielis self-assigned this Jan 14, 2025
@ielis
Copy link
Member

ielis commented Jan 15, 2025

I addressed this in #391. However, I added a new VariantEffect enum member, VariantEffect.TRANSCRIPT_TRANSLOCATION, which corresponds to transcript_translocation SO:0001883.

@pnrobinson pls give this 👍 if it sounds OK.

@pnrobinson
Copy link
Member Author

That is a better SO term than the one I was using in pyphetools, but let us go for it. This meqns we will have to use another version of ppkt store

@ielis
Copy link
Member

ielis commented Jan 15, 2025

OK, let's close then.

@ielis ielis closed this as completed Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants