Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow merging Cohorts #294

Open
ielis opened this issue Oct 2, 2024 · 2 comments
Open

Allow merging Cohorts #294

ielis opened this issue Oct 2, 2024 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@ielis
Copy link
Member

ielis commented Oct 2, 2024

We may want to overload __add__ or __or__ operators on Cohort to allow merging two cohorts, because a cohort is essentially a set of individuals. The merge can succeed as long as there is no individual with the same ID present in both cohorts.

@ielis ielis added the enhancement New feature or request label Oct 2, 2024
@ielis ielis added this to the Nice to have milestone Oct 2, 2024
@pnrobinson
Copy link
Member

It seems to be just as easy to "extend" lists of phenopackets, so not sure that we need this additional function? @ielis

@ielis
Copy link
Member Author

ielis commented Oct 28, 2024

The flip side of merging phenopackets is that we must do Q/C and functional annotation to go from phenopacket -> cohort, while if we merge Cohorts, we are already past that. So, the only thing to verify is that the variants are on the same build, HPO on the same version, and the sets of individuals are disjoint.

However, it is indeed probably a low priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants