We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently, we have this:
from gpsea.view import CohortViewable cv = CohortViewable(hpo=hpo) report = cv.process(cohort=cohort, transcript_id=POLR1A_MANE_transcript) display(HTML(report))
but the report object is only used here. We could simplify the API by allowing something like this:
report
from gpsea.view import CohortViewable display(HTML(CohortViewable.to_html(hpo=hpo, cohort=cohort, transcript_id=POLR1A_MANE_transcript)))
It would be great to reduce the number of lines of code for the Notebooks in general, this would help users!
The text was updated successfully, but these errors were encountered:
Yeah, this could be turned into a free function that uses CohortViewable (CohortSummaryViewer would be a better name) under the hood.
CohortViewable
CohortSummaryViewer
So, instead of exporting CohortViewable from gpsea.view, there should be a function
gpsea.view
def summarize_cohort(cohort: Cohort, hpo: hpotk.MinimalOntology, tx_id: str) -> str: # Implement! pass
which we should use as
from gpsea.view import summarize_cohort summary = summarize_cohort(cohort, hpo, tx_id=POLR1A_MANE_transcript) display(HTML(summary))
Sorry, something went wrong.
No branches or pull requests
Currently, we have this:
but the
report
object is only used here. We could simplify the API by allowing something like this:It would be great to reduce the number of lines of code for the Notebooks in general, this would help users!
The text was updated successfully, but these errors were encountered: