Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add key with colors and names of protein ffeatures #171

Closed
pnrobinson opened this issue May 28, 2024 · 5 comments
Closed

add key with colors and names of protein ffeatures #171

pnrobinson opened this issue May 28, 2024 · 5 comments
Assignees

Comments

@pnrobinson
Copy link
Member

For each unique feature name, use the same color. If the name is more than 5 characters, use an abbreviation (e.g., "A", "B", etc...) in the main protein figure.
Add a legend with one row per feature that shows a color box, the abbreviation if any, and the full name

Do the same for the variant class lollipops

@frehburg
Copy link
Collaborator

image

New params:

  • labeling_method: either enumerate (A, B, C, ...) or abbreviate (first 5 chars) the feature name. Figure resizes accordingly
  • legend_x: move the legend around, by default right of figure to not overlap with the variant markers

@pnrobinson
Copy link
Member Author

Looks great! Wow!
PS -- vielleicht so was Ähnliches für die Lollipops?

@pnrobinson
Copy link
Member Author

@frehburg
Please add adjust the title of the graphic.
Protein name should come from protein_meta.label (and not be the accession number). Also please remove "Working title"!

@ielis
Copy link
Member

ielis commented Jun 1, 2024

I fixed the title and added the protein name, the updated code is already in develop.

The rest of this issue is, however, most likely still current.

@pnrobinson
Copy link
Member Author

redundant with #124
closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants