Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Evaluation of Trends and Threat, and synthesis" no propability #284

Closed
KonzeptAcht opened this issue May 8, 2020 · 9 comments
Closed

Comments

@KonzeptAcht
Copy link

Describe the bug
For MONARC databases updated from older MOARC versions, the "Evaluation of Trends and Threat, and synthesis" in the "Threats assessment" section offers two more lines for the "probability".

In risk analyses that are newly created in version 2.9.14, this “probability” is no longer available. This behavior affects our own installation as well as our instance in my.monarc.lu.

To Reproduce
Steps to reproduce the behavior:

  1. Open Step 1 "Evaluation of Trends and Threat, and synthesis" and select "Threats assessment
    "
  2. in older risk analyses there is the possibility to make a probability assessment
  3. in newer versions "after 2.9.14" this option is no longer available

Expected behavior
There is the possibility to carry out a probability assessment

Screenshots
Older risk analyses
alt text

Newer risk analyses
alt text

Desktop (please complete the following information):

Questions Answers
Type of issue Bug
OS version (server) Ubuntu LTS 18.04
OS version (client) MacOS, Win10
PHP version 7.3
MONARC version / git hash 2.9.14
Browser Firefox, Chrome, Safari
@jerolomb
Copy link
Contributor

jerolomb commented May 8, 2020

Hello,

Excepting a bug if you want to see the probability line, you have to tick the "definition of the risk evaluation criteria"

image

I hope, it helps

@KonzeptAcht
Copy link
Author

Okay, thanks for the advice @jerolomb . We've just reproduced this.However, we do not believe it is useful to pre-empt a hook in a downstream step. Since no one will then make a probability assessment after they have already completed the step for themselves.

@jerolomb
Copy link
Contributor

jerolomb commented May 8, 2020

it's just because the scale of the probability is defined in this steps, and if you set a probability you can't change anymore the scales. Thanks for your feedback.

@jerolomb jerolomb closed this as completed May 8, 2020
@KonzeptAcht
Copy link
Author

It is currently problematic mainly because this does not correspond to the procedure of the web interface and the procedure trained by you. Would it not be possible to at least display the probability evaluation function, grey it out and provide a hint why this part cannot yet be edited?

@tkochanek-K8
Copy link

How about changing the order of sub-processes?

  • Risks analysis context
  • Risks management organisation
  • Definition of the risk evaluation criteria
  • Evaluation of Trends and Threat, and synthesis

And everything is fine again.. :-)

@cedricbonhomme
Copy link
Member

Yes, it would be a solution.

An other solution is to display it, but in a first step disable it (it will be greyed). Then when "definition of the risk evaluation criteria" is ticked it will be accessible.

@KonzeptAcht
Copy link
Author

@cedricbonhomme Could you reopen the ticket then?

@ruslanbaidan
Copy link
Contributor

Originally the ticket has been created as a bug, but as we found this is a new functionality.
Created a feature request: #292

@KonzeptAcht
Copy link
Author

Ok, thanks @ruslanbaidan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants