Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on Special Characters in Track Names #571

Open
GoogleCodeExporter opened this issue Dec 28, 2015 · 4 comments
Open

Crash on Special Characters in Track Names #571

GoogleCodeExporter opened this issue Dec 28, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

1) Please describe the steps to reproduce the situation:
a. Take a CD with Tracks with special Characters (e.g. German Umlauts)
b. Start Rip
c. Ruby Crashes

2) What is the expected output? What do you see instead?

No Crash 

3) What version of rubyripper are you using? On what operating system? The
gtk2 of commandline interface?

ArchLinux, latest Version of RubyRipper, gtk2.

4) Is this not already fixed with the latest & greatest code? See for
instructions the Source tab above.s.

Don't think so.

6) Please explain why this change is important for you. Also, how many
users would benefit from this change?

I have quite some CDs with german Umlauts as well as french characters.

I guess that the problem is the transformation of these special characters. The 
translation of these characters should be somewhat configurable, in that I 
would like to translate ä to ae, ü to ue and ö to oe ;-) Probably the french 
characters could be translated as well.

Original issue reported on code.google.com by [email protected] on 30 May 2013 at 8:07

@GoogleCodeExporter
Copy link
Author

I guess, that the method filter(item) in filterFiles.rb should be adopted, to 
support the functionality described in 
http://www.jroller.com/obie/tags/unicode. 

This provides a way to use a translation-table, which could be extended and to 
clean up filenames according to the filesystem standards of all systems (it 
should be ascii only IMHO, and also we should remove , and . from the real 
filename, because these suck).

What do you think?

Original comment by [email protected] on 10 Jun 2013 at 4:30

@GoogleCodeExporter
Copy link
Author

I don't think it shouldn't crash with special characters as long as the target 
filesystem supports UTF-8. This has always worked correctly as far as I know.

Original comment by [email protected] on 15 Jun 2013 at 2:36

@GoogleCodeExporter
Copy link
Author

This has certainly NOT always worked correctly. At least for me, 0.6.2 crashes 
if there are non-ASCII characters in the metadata. I'm not sure about the 
latest Git master.

Original comment by [email protected] on 19 Oct 2013 at 11:29

@GoogleCodeExporter
Copy link
Author

This seems to be a duplicate of 
http://code.google.com/p/rubyripper/issues/detail?id=449.

Original comment by [email protected] on 19 Oct 2013 at 3:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant