Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update phoenix_html to 4.0.0 #448

Closed
adamu opened this issue Jan 22, 2024 · 5 comments
Closed

Update phoenix_html to 4.0.0 #448

adamu opened this issue Jan 22, 2024 · 5 comments

Comments

@adamu
Copy link
Contributor

adamu commented Jan 22, 2024

phoenix_html has been updated to v4 with breaking changes: https://hexdocs.pm/phoenix_html/changelog.html#v4-0-0-2023-12-19

I took a look at doing the migration myself, but I'm guessing this library will want to do more than the minimal changes to update and keep the code compiling, it'll probably want to avoid the dependency on the new (legacy) phoenix_html_helpers library, so I'm just opening the issue for now.

@cpjolicoeur
Copy link
Member

Thanks for this @adamu

@noahduncan noahduncan self-assigned this Mar 12, 2024
@adamu
Copy link
Contributor Author

adamu commented Apr 3, 2024

@cpjolicoeur Is there any progress on this? If you like I can work on a PR that introduces the phoenix_html_helpers library, which would stop Torch being a blocker for people updating to phoenix_html v4.

@adamu
Copy link
Contributor Author

adamu commented Apr 22, 2024

I think this can be closed now following #452 and the latest release (but heads up that the Hex docs appear to be broken).

@cpjolicoeur
Copy link
Member

Thanks @adamu I'm not sure what is up with the docs but I'll look into it and republish them

@cpjolicoeur
Copy link
Member

@adamu docs have been fixed and re-published. Thanks for noticing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants