Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling in the library :) #1

Open
fgimian opened this issue Dec 29, 2018 · 0 comments
Open

Error handling in the library :) #1

fgimian opened this issue Dec 29, 2018 · 0 comments

Comments

@fgimian
Copy link

fgimian commented Dec 29, 2018

Hey Vladimir,

Great job on this library, it parses my UDF ISOs perfectly.

I notice at the moment that the code has quite a lot of panics instead of returning errors when things go wrong. As such, the library panics if an invalid file is read with it.

Would you consider adding some error handling to your library so it is more robust?

Thanks so much!
Fotis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant