Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static Plugins trigger pdoToolsOnFenomInit even if not defined as their Event #380

Open
darQrrR opened this issue Jun 13, 2024 · 0 comments
Labels

Comments

@darQrrR
Copy link

darQrrR commented Jun 13, 2024

Summary

Static Plugins won't trigger their respective System Events if ANY other plugin has pdoToolsOnFenomInit as theirs (i.e. ClientConfig). Instead they will also trigger pdoToolsOnFenomInit even if it is not defined as their System Event. Tested on a fresh installation.

Steps to reproduce

  • Enable pdotools_fenom_parser in System Settings
  • Add regular Plugin, add pdoToolsOnFenomInit as System Event
  • Add static Plugin, add OnLoadWebDocument or any other Event
  • Log triggered event

Observed behavior

Static Plugin triggers pdoToolsOnFenomInit, not OnLoadWebDocument

Expected behavior

Static Plugin should trigger OnLoadWebDocument

Solution

  • When Plugin with pdoToolsOnFenomInit is disabled, static plugin will trigger correctly again
  • When static is disabled for static plugin, event will correctly again as well

Environment

MODX 3.0.5
pdoTools 3.0.2

@darQrrR darQrrR added the bug label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant