Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI places Linux packages into subdirectories of archive in CI GUI, instead of publishing them independently at /releases. #2847

Open
2 tasks done
RokeJulianLockhart opened this issue Oct 21, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@RokeJulianLockhart
Copy link

RokeJulianLockhart commented Oct 21, 2024

Please confirm the following.

Describe the bug

As @Flatfire explains at #2515 (comment) (paraphrased):

The RPM did build, and is available in the build artefacts for 0.8.9, but, yes, for some strange reason, unlike 0.8.8, it did not link properly on the home page. It's actually included in the "Ubuntu 22.04.zip" file found at https://github.com/modrinth/code/actions/runs/11360474470. I believe there are some shenanigans to be resolved here.

Specifically, https://github.com/modrinth/code/actions/runs/11360474470/artifacts/2061896393 includes a useless release directory, within which are appimage, deb, and rpm directories, containing their respective package files:

Image

Steps to reproduce

Rerun https://github.com/modrinth/code/actions/runs/11360474470.

Expected behavior

Separate .RPM, .Deb, and .AppImage packages should have been published by the CI to the entry in /releases that corresponds to their version.

Additional context

  1. tree '.' # The extracted contents of the `.zip`.
  2. .
    └── release
        └── bundle
            ├── appimage
            │   ├── Modrinth App_0.8.8_amd64.AppImage
            │   ├── Modrinth App_0.8.8_amd64.AppImage.tar.gz
            │   └── Modrinth App_0.8.8_amd64.AppImage.tar.gz.sig
            ├── deb
            │   ├── Modrinth App_0.8.8_amd64.deb
            │   └── Modrinth App_0.8.9_amd64.deb
            └── rpm
                ├── Modrinth App-0.8.8-1.x86_64.rpm
                └── Modrinth App-0.8.9-1.x86_64.rpm
    
    6 directories, 7 files
    
@RokeJulianLockhart RokeJulianLockhart added the bug Something isn't working label Oct 21, 2024
@RokeJulianLockhart RokeJulianLockhart changed the title CI places .RPM package inside .Deb. CI places Linux packages' contents into subdirectories of archive, instead of as separate package files. Oct 21, 2024
@RokeJulianLockhart RokeJulianLockhart changed the title CI places Linux packages' contents into subdirectories of archive, instead of as separate package files. CI places Linux packages into subdirectories of archive in CI GUI, instead of publishing them at /releases. Oct 21, 2024
@RokeJulianLockhart RokeJulianLockhart changed the title CI places Linux packages into subdirectories of archive in CI GUI, instead of publishing them at /releases. CI places Linux packages into subdirectories of archive in CI GUI, instead of publishing them independently at /releases. Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

1 participant