Revert fields to original types #138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ything as a string. This solves not knowing if a properties field should be decoded or not.
… value types. Shrink varchar size to 7. Code tweaks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still testing...
The new fields might be better off as a combined properties field. 🤔
There are some issues reverting properties fields. We can't just decode or deserialize all properties when reverting because some may be intended to be that way.
This PR adds a way to keep track of what the value type was before it was added to the delta field. This way we can serialize an array when creating a delta, and then we know that it needs to be unserialized when reverting.
It also will allow an integer to be recreated as an integer etc.
This also fixes a bug with a blank array key being created when splitting property fields recursively.