-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MODELIX-721 Migrate cucumber tests for model-server to ktor tests #873
Conversation
Test Results143 files +2 143 suites +2 10m 59s ⏱️ +14s Results for commit c473039. ± Comparison against base commit 601ef68. This pull request removes 16 and adds 17 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
JVM coverage report
|
model-server/src/main/kotlin/org/modelix/model/server/handlers/ui/IndexPage.kt
Fixed
Show resolved
Hide resolved
|
||
class IndexPage { | ||
|
||
fun init(application: Application) { |
Check warning
Code scanning / detekt
The function init is missing documentation. Warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know the reasons for why some of the cucumber scenarios were commented out? Is it safe to drop them?
Apart from that, only minor things that I added.
After #862, kotest assertions would now also be available as an option.
model-server/src/main/kotlin/org/modelix/model/server/handlers/ui/IndexPage.kt
Fixed
Show resolved
Hide resolved
model-server/src/test/kotlin/org/modelix/model/server/V1ApiTest.kt
Outdated
Show resolved
Hide resolved
model-server/src/test/kotlin/org/modelix/model/server/handlers/HealthApiTest.kt
Outdated
Show resolved
Hide resolved
model-server/src/main/kotlin/org/modelix/model/server/handlers/ui/IndexPage.kt
Outdated
Show resolved
Hide resolved
308c398
to
e13c51b
Compare
e13c51b
to
4c3892c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good idea with the plugin.
The only thing potentially left is that we have the exact same logic now copied to two tests, which could be deduplicated.
4c3892c
to
c473039
Compare
🎉 This PR is included in version 8.13.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
On my local machine the migrated test cases now only take 2s instead of 38s.
The saved 36s are roughly a 40% reduction of the previous total time to test the model-server.
To be verified by reviewers