From 9f86ee599876c5540444bacd77cdc2ebe7dfb06e Mon Sep 17 00:00:00 2001
From: David Soria Parra <davidsp@anthropic.com>
Date: Mon, 13 Jan 2025 13:01:46 +0000
Subject: [PATCH] fix: fix scripts

---
 .github/workflows/release-check.yml | 18 ++++++++++++++----
 .github/workflows/release.yml       |  2 +-
 scripts/release.py                  |  2 +-
 3 files changed, 16 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/release-check.yml b/.github/workflows/release-check.yml
index d4fc9ed1..005f460c 100644
--- a/.github/workflows/release-check.yml
+++ b/.github/workflows/release-check.yml
@@ -30,6 +30,8 @@ jobs:
   check-release:
     needs: prepare
     runs-on: ubuntu-latest
+    outputs:
+      release: ${{ steps.check.outputs.release }}
     strategy:
       matrix:
         directory: ${{ fromJson(needs.prepare.outputs.matrix) }}
@@ -53,8 +55,15 @@ jobs:
         run: uv python install
 
       - name: Check release
+        id: check
         run: |
-          uv run --script scripts/release.py --dry-run "${{ matrix.directory }}" "${{ needs.prepare.outputs.last_release }}" | tee -a "$GITHUB_OUTPUT"
+          output=$(uv run --script scripts/release.py --dry-run "${{ matrix.directory }}" "${{ needs.prepare.outputs.last_release }}" \
+            | grep -o -E "[a-zA-Z0-9\-]+@[0-9]+\.[0-9]+\.[0-9]+" || true)
+          if [ ! -z "$output" ]; then
+            echo "release<<EOF" >> $GITHUB_OUTPUT
+            echo "$output" >> $GITHUB_OUTPUT
+            echo "EOF" >> $GITHUB_OUTPUT
+          fi
 
   check-tag:
     needs: [prepare, check-release]
@@ -64,7 +73,8 @@ jobs:
 
       - name: Simulate tag creation
         run: |
-          if [ -s "$GITHUB_OUTPUT" ]; then
+          echo "${{ needs.check-release.outputs.release }}" > packages.txt
+          if [ -s packages.txt ]; then
             DATE=$(date +%Y.%m.%d)
             echo "🔍 Dry run: Would create tag v${DATE} if this was a real release"
 
@@ -72,8 +82,8 @@ jobs:
             echo "" >> notes.md
             echo "## Updated Packages" >> notes.md
             while IFS= read -r line; do
-              echo "- ${line}" >> notes.md
-            done < "$GITHUB_OUTPUT"
+              echo "- $line" >> notes.md
+            done < packages.txt
 
             echo "🔍 Would create release with following notes:"
             cat notes.md
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index d2d808b4..d2d084de 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -64,7 +64,7 @@ jobs:
         env:
           NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
           UV_PUBLISH_TOKEN: ${{ secrets.PYPI_TOKEN }}
-        run: uv run --script scripts/release.py "${{ matrix.directory }}" "${{ needs.prepare.outputs.last_release }}" >> "$GITHUB_OUTPUT"
+          run: uv run --script scripts/release.py "${{ matrix.directory }}" "${{ needs.prepare.outputs.last_release }}" >> "$GITHUB_OUTPUT"
 
   create-release:
     needs: [prepare, release]
diff --git a/scripts/release.py b/scripts/release.py
index 0853d36e..17329560 100755
--- a/scripts/release.py
+++ b/scripts/release.py
@@ -171,7 +171,7 @@ def main(directory: Path, git_hash: GitHash, dry_run: bool) -> int:
         if not dry_run:
             click.echo(f"{name}@{version}")
         else:
-            click.echo(f"🔍 Dry run: Would have published {name}@{version} if this was a real release")
+            click.echo(f"Dry run: Would have published {name}@{version}")
         return 0
     except Exception as e:
         return 1