Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick cleanup to make each test name/node id unique #32

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

freider
Copy link
Collaborator

@freider freider commented Oct 22, 2024

Now, running pytest -v will display things like:

modal/app.py::App[CodeBlock#1][rel.line:17] PASSED
...

and individual test items can be selected using the same name, e.g.
pytest --markdown-docs modal/app.py::App[CodeBlock#1][rel.line:17]

Not 100% sure on the syntax of the items, and it would be nice to fix the outstanding issue of not having absolute line numbers to docstring-inlined code fences, but this is at least an improvement over the status quo

@freider freider requested a review from mwaskom October 22, 2024 07:52
@freider
Copy link
Collaborator Author

freider commented Oct 22, 2024

@prbot approve

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍. @mwaskom will follow-up review this.

@freider freider merged commit 5033f08 into main Oct 22, 2024
6 checks passed
@freider freider deleted the freider/test-item-naming branch October 22, 2024 07:53
Copy link

@mwaskom mwaskom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants