add spindown parameter #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- once Margo has begun spinning in the progress loop, check configurable "spindown" time to see if it should continue for some period of time before reverting to normal behavior
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #294 +/- ##
==========================================
+ Coverage 57.86% 57.88% +0.01%
==========================================
Files 70 70
Lines 10165 10181 +16
Branches 1334 1337 +3
==========================================
+ Hits 5882 5893 +11
- Misses 3451 3453 +2
- Partials 832 835 +3 ☔ View full report in Codecov by Sentry. |
|
Performance results are great. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that once Margo starts to busy spin (because of in flight RPCs or active ULTs in the progress pool) , it will continue to do so for a brief, configurable period of time.
The intent is to make Margo slightly less aggressive about entering an idle mode. It should improve performance particularly for sequential workloads that have small rtt gaps between operations.
Need to performance test before merging but I want to go ahead and open a PR so that it can to through github CI checks.